-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wordgrinder: Fix build #60122
wordgrinder: Fix build #60122
Conversation
The What has changed in this regard is not the way builds are handled in So using 1 It might however change one day if we leverage |
Ready for squashing here. |
@@ -18,6 +18,10 @@ stdenv.mkDerivation rec { | |||
"LUA_LIB=${lua52Packages.lua}/lib/liblua.so" | |||
] ++ stdenv.lib.optional stdenv.isLinux "XFT_PACKAGE=--libs=\{-lX11 -lXft\}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] ++ stdenv.lib.optional stdenv.isLinux "XFT_PACKAGE=--libs=\{-lX11 -lXft\}"; | |
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have this in preRebuild
, so no need to duplicate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hang on...
fb7da53
to
72bfbb0
Compare
72bfbb0
to
4186e07
Compare
Ready here, if you (@aszlig) don't mind the commit message 😄 |
First I tried to fix the build like this: > This fixes the build of the wordgrinder package by disabling the build > of "xwordgrinder", the non-curses frontend of wordgrinder. > > For re-enabling the build, this patch shall be reverted and then go on > from there. > > I opted for disabling the x frontend of this program because the whole > purpose of this is to use a curses writing program (at least for me). > It seems that hacking around the new build system in nixpkgs is a > non-trivial task and I wanted to get this package out of the door as > fast as possible because I already delayed the fix by a few days (or is > it weeks already), so this is the simple fix. > > If someone wants to have the X frontend again, I can invest more time at > some point. But then the almighty aszlig came around and told me how to do it right. So here we go, with a patch from me that is acutally from aszlig (see NixOS#60122). This fixes the build. Suggested-by: @aszlig Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Fixes: 6b2bd33 ("wordgrinder: Fix sha256 hash") Fixes: 19a3abc ("wordgrinder: 0.7.1 -> 0.7.2") CC: @aszlig CC: @devhell
4186e07
to
45841f5
Compare
This can be merged, right? |
First I tried to fix the build like this: > This fixes the build of the wordgrinder package by disabling the build > of "xwordgrinder", the non-curses frontend of wordgrinder. > > For re-enabling the build, this patch shall be reverted and then go on > from there. > > I opted for disabling the x frontend of this program because the whole > purpose of this is to use a curses writing program (at least for me). > It seems that hacking around the new build system in nixpkgs is a > non-trivial task and I wanted to get this package out of the door as > fast as possible because I already delayed the fix by a few days (or is > it weeks already), so this is the simple fix. > > If someone wants to have the X frontend again, I can invest more time at > some point. But then the almighty aszlig came around and told me how to do it right. So here we go, with a patch from me that is acutally from aszlig (see #60122). This fixes the build. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: aszlig <aszlig@nix.build> Fixes: 6b2bd33 ("wordgrinder: Fix sha256 hash") Fixes: 19a3abc ("wordgrinder: 0.7.1 -> 0.7.2") Merges: #60122 Cc: @devhell
Merged in 31bee0c. |
This fixes the build of the wordgrinder package by disabling the build
of "xwordgrinder", the non-curses frontend of wordgrinder.
For re-enabling the build, this patch shall be reverted and then go on
from there.
I opted for disabling the x frontend of this program because the whole
purpose of this is to use a curses writing program (at least for me).
It seems that hacking around the new build system in nixpkgs is a
non-trivial task and I wanted to get this package out of the door as
fast as possible because I already delayed the fix by a few days (or is
it weeks already), so this is the simple fix.
If someone wants to have the X frontend again, I can invest more time at
some point.
Fixes: 6b2bd33 ("wordgrinder: Fix sha256 hash")
Fixes: 19a3abc ("wordgrinder: 0.7.1 -> 0.7.2")
CC: @aszlig
CC: @devhell
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)