Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pazi: init at 0.2.0 #60303

Merged
merged 2 commits into from Apr 27, 2019
Merged

pazi: init at 0.2.0 #60303

merged 2 commits into from Apr 27, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 27, 2019

Motivation for this change

Add pazi. A supposedly fast autojump tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks! :)
If I haven't missed anything the derivation looks good, too.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pazi/default.nix Outdated Show resolved Hide resolved
@bbigras
Copy link
Contributor Author

bbigras commented Apr 27, 2019

Thanks for the quick review.

@teto
Copy link
Member

teto commented Apr 27, 2019

looks good. Do you plan to add the shell completion scripts ?

@FRidh FRidh merged commit 555f464 into NixOS:master Apr 27, 2019
@bbigras bbigras deleted the pazi branch April 27, 2019 11:58
@bbigras
Copy link
Contributor Author

bbigras commented Apr 27, 2019

looks good. Do you plan to add the shell completion scripts ?

@teto I forgot about that but yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @teto @JohnAZoidberg @FRidh