New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luarocks-nix,luaPackages: formatting and additions; awesome: docs! #60343
luarocks-nix,luaPackages: formatting and additions; awesome: docs! #60343
Conversation
Seems fine from the first reading |
Overall fine. |
Mostly formatting improvements, basexx apparently has new version which was picked up.
* no leading whitespace * collapse consecutive blank lines to single line * indent fromJSON bits
Especially useful when using non-release versions, but good to have locally regardless.
93417fa
to
403ce6a
Compare
Whoa I thought was merged :3, thanks! |
Motivation for this change
I wanted the wonderful generated docs from awesome,
but needed some new lua modules for this to happen.
Along the way worked on formatting generated by luarocks-nix,
but even so ultimately did a bit of post-processing.
Marking draft because I don't want to actually point to my fork
but haven't sent the changes upstream
(which may need some tweaks or whatnot to be satisfactory).
cc @teto
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)