check-meta: use system tuple in platforms #60349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
requested review from
edolstra,
Ericson2314 and
nbp
as code owners
|
Thanks for working on this! Just a heads up, since checks failing don't send a notification: |
|
@GrahamcOfBorg eval |
This was never listed in doubles.nix! Not sure why?
|
Shouldn't you be able to remove lib.systems.forMeta and for-meta.nix with this? |
|
Yeah probably ok to do that |
This is unused now.
This makes things a little bit more convenient. Just pass in like: $ nix-build ’<nixpkgs>’ -A hello --argstr localSystem x86_64-linux --argstr crossSystem aarch64-linux
matthewbauer
added a commit
that referenced
this pull request
Jun 4, 2019
in #60349, the attr handling was removed. This means we rely on these double values for determing what we are compatible with. This adds some of the missing doubles to this list. https://hydra.nixos.org/eval/1523389#tabs-removed
matthewbauer
added a commit
to matthewbauer/nixpkgs
that referenced
this pull request
Jul 8, 2019
These are used in cross-compilation to iOS devices and simulators. Fallout from NixOS#60349.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60345
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)