Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-pack: Update hash. #60892

Merged
merged 1 commit into from May 4, 2019
Merged

wasm-pack: Update hash. #60892

merged 1 commit into from May 4, 2019

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented May 3, 2019

The previous hash was generated on aarch64. Due to #60668 the hash is different on different platforms. I am updating to use the x86_64-linux hash to fix building on hydra.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox
wasm-pack: Update hash.
bd78d55 
The previous hash was generated on aarch64. Due to #60668 the hash is different on different platforms. I am updating to use the x86_64-linux hash to fix building on hydra.
@kevincox kevincox mentioned this pull request May 3, 2019
Merged
10 tasks
@kevincox kevincox merged commit e90a6f0 into master May 4, 2019
@grahamc grahamc deleted the kevincox-hash-fix branch December 28, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kevincox