Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fiona: fix tests on py27 by including mock in checkInputs #60936

Merged
merged 1 commit into from May 5, 2019
Merged

pythonPackages.fiona: fix tests on py27 by including mock in checkInputs #60936

merged 1 commit into from May 5, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 4, 2019

Motivation for this change

Noticed this fails when reviewing #60716

Depending package cartopy still fails to build, but I think I can remedy that in another PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner May 4, 2019 18:40
@risicle risicle mentioned this pull request May 4, 2019
Merged
10 tasks
@marsam
Copy link
Contributor

marsam commented May 5, 2019

@GrahamcOfBorg build pythonPackages.fiona python3Packages.fiona

@marsam
Copy link
Contributor

marsam commented May 5, 2019

@GrahamcOfBorg build pythonPackages.fiona python3Packages.fiona

@marsam marsam merged commit 9da759e into NixOS:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam requested changes

@knedlsepp knedlsepp knedlsepp approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @marsam @knedlsepp