Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus_2: 2.8.1 -> 2.9.2 #61006

Merged
merged 1 commit into from May 6, 2019
Merged

prometheus_2: 2.8.1 -> 2.9.2 #61006

merged 1 commit into from May 6, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented May 5, 2019

Motivation for this change

https://github.com/prometheus/prometheus/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I am using 2.9.2 and it seems to work fine.

@ivan ivan mentioned this pull request May 5, 2019
Closed
10 tasks
@marsam
Copy link
Contributor

marsam commented May 6, 2019

@GrahamcOfBorg build prometheus_2

@marsam marsam merged commit 4e414a1 into NixOS:master May 6, 2019
@marsam
Copy link
Contributor

marsam commented May 6, 2019

Tested locally. Thanks @ivan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @marsam