Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.lark-parser: enable majority of tests #61062

Merged
merged 1 commit into from May 11, 2019

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented May 6, 2019

Motivation for this change

This is a draft PR because it sits on top of #59661 - will rebase once that's merged. Done.

Looks like most of lark-parser's tests are fine, we just have to disable the tests of Nearley.js support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle force-pushed the ris-lark-parser-enable-tests branch from b4228e9 to 8b9883a May 7, 2019
@risicle risicle marked this pull request as ready for review May 7, 2019
@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 11, 2019

@GrahamcOfBorg build python27Packages.lark-parser python37Packages.lark-parser

@c0bw3b c0bw3b merged commit 1a262d0 into NixOS:master May 11, 2019
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants