Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.streamz: fix checks failures #61099

Merged
merged 1 commit into from May 7, 2019
Merged

pythonPackages.streamz: fix checks failures #61099

merged 1 commit into from May 7, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 7, 2019

Motivation for this change

streamz-dataframe tests are failing consistently
-> remove them for now
cc @costrouc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b requested a review from FRidh as a code owner May 7, 2019 18:56
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 7, 2019

@GrahamcOfBorg build python27Packages.streamz python37Packages.streamz

@c0bw3b
pythonPackages.streamz: fix checks failures
d7095b2 
streamz-dataframe tests are failing consistently
-> remove them for now
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 7, 2019

Just to be sure

Result of nix-review pr 61099 1

2 package were build:
  • python27Packages.streamz
  • python37Packages.streamz

@c0bw3b c0bw3b merged commit 3ad6162 into NixOS:master May 7, 2019
@c0bw3b c0bw3b deleted the fix/streamz branch May 7, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @worldofpeace