Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethtool: 5.0 -> 5.1 #61640

Merged
merged 1 commit into from May 18, 2019
Merged

ethtool: 5.0 -> 5.1 #61640

merged 1 commit into from May 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 17, 2019

Motivation for this change

https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/tree/NEWS?id=cabc523cd2c398f63cd6198deb35039b2f08484f

Staging since network-manager and other net-infra bits use this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor May 17, 2019 20:29
@dtzWill dtzWill merged commit 7ea7c5c into NixOS:staging May 18, 2019
@dtzWill dtzWill deleted the update/ethtool-5.1 branch May 18, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @bjornfor