Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcom-sta: patch for 5.1+ #61662

Closed
wants to merge 1 commit into from
Closed

Conversation

rembo10
Copy link
Contributor

@rembo10 rembo10 commented May 18, 2019

Motivation for this change

The broadcom-sta package wasn't compiling on kernel 5.1.0. It calls a get_ds() function, which was removed. get_ds() was simply defined as KERNEL_DS, so replacing that function call with KERNEL_DS seems to have fixed things. I pulled the patch from archlinux. Here are some relevant bug reports:
https://bugs.gentoo.org/685214
https://bugs.archlinux.org/task/62604

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rembo10
Copy link
Contributor Author

rembo10 commented May 20, 2019

I'll close this in favor of #61686

@rembo10 rembo10 closed this May 20, 2019
@rembo10 rembo10 mentioned this pull request May 20, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant