Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microwindows: init at unstable-2019-05-20 #61837

Closed
wants to merge 1 commit into from

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented May 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bignaux
Copy link
Contributor Author

@bignaux bignaux commented May 21, 2019

@GrahamcOfBorg build microwindows

Copy link
Member

@aanderse aanderse left a comment

@bignaux I'm terribly sorry this has sat so long without attention. A few changes I have outlined which I hope you will find helpful.

pkgs/servers/microwindows/default.nix Outdated Show resolved Hide resolved
pkgs/servers/microwindows/default.nix Show resolved Hide resolved
pkgs/servers/microwindows/default.nix Outdated Show resolved Hide resolved
pkgs/servers/microwindows/default.nix Outdated Show resolved Hide resolved
pkgs/servers/microwindows/default.nix Show resolved Hide resolved
@stale
Copy link

@stale stale bot commented Jun 11, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@bignaux bignaux closed this Oct 13, 2020
@bignaux bignaux deleted the microwindows branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants