Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lumina.lumina: 1.4.0-p1 -> 1.5.0 #62035

Merged
merged 5 commits into from May 27, 2019
Merged

lumina.lumina: 1.4.0-p1 -> 1.5.0 #62035

merged 5 commits into from May 27, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 25, 2019

Motivation for this change

lumina: move to pkgs/desktops/lumina/lumina
lumina: init package set for the lumina desktop
lumina.lumina: 1.4.0-p1 -> 1.5.0
lumina.lumina-calculator: init at 2019-04-27
lumina.lumina-pdf: init at 2019-04-27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 62035 1

3 package were build:
  • lumina.lumina
  • lumina.lumina-calculator
  • lumina.lumina-pdf

I have not tested the complete desktop env but calculator, pdf viewer, photo viewer, mediaplayer, textedit, etc... run fine

@romildo romildo merged commit 00d6232 into NixOS:master May 27, 2019
@romildo romildo deleted the upd.lumina branch May 27, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @c0bw3b