New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxPackages.nvidia_x11_legacy390: use patches from archlinux #62064
linuxPackages.nvidia_x11_legacy390: use patches from archlinux #62064
Conversation
It'd be awesome if @vaibhavsagar or somebody else with the hardware could see if this works on both master, and if backported to 19.03. |
I don't know how to change my system |
@vaibhavsagar While calling You probably want to checkout the |
You might prefer |
(fetchurl { | ||
url = "https://git.archlinux.org/svntogit/packages.git/plain/trunk/kernel-5.1.patch?h=42d50ef8d6048608d18bdf2c296dd335260c5a1a"; | ||
sha256 = "03v46ym2bcckg9q2xrilkg21hfiwypr6gl4jmly2q3m4yza9ja6r"; | ||
})]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file should be deleted, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgs/os-specific/linux/nvidia-x11/drm_mode_connector.patch
didn't apply cleanly anymore. I deleted it now and updated the commit.
I wanted to stick with what archlinux provides, as their patches use #if LINUX_VERSION_CODE < KERNEL_VERSION(…)
and seem to apply on recent kernels.
Those seem to have gotten outdated, and don't build on current kernels anymore. Reported-In: NixOS#62012
c2cd3a9
to
00263c9
Compare
Maybe But as I said, this will switch the system to unstable (until next rebuild-switch), so manually cherry-picking might be more suitable. |
Hmm, right, I didn't notice 19.03 was wanted. GitHub provides nice git branches for pull requests (by number), but I can't see similar archive URLs. |
I manually cherry-picked onto |
Glad to hear! Merged in and backported to 19.03 in c8124c1. |
Thanks so much! |
Those seem to have gotten outdated, and don't build on current kernels
anymore.
Reported in #62012
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)