Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: Update #62724

Merged
merged 1 commit into from Jun 6, 2019
Merged

vimPlugins: Update #62724

merged 1 commit into from Jun 6, 2019

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Jun 5, 2019

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jun 5, 2019

while at it could you please update the neomake repo to neomake/neomake https://github.com/neomake/neomake/ ? the current nixpkgs one hasn't been updated in ages.
(was planning to do it myself but as you want to update vimPlugins :p)

@rvolosatovs
Copy link
Member Author

@teto Done.
Neomake did not get updated though(https://github.com/NixOS/nixpkgs/compare/84b34d295d35308189b84b57817f7ebebce1f58a..bb27e0fe6bfcf4ded9ffee144b88bdbc24e61b13)
I suppose it's because the old repo was moved, so it just points to the new one

@teto
Copy link
Member

teto commented Jun 6, 2019

seems like it did get updated. Add neovimhaskell/nvim-hs.vim in another commit "vimPlugins.nvim-hs-vim: init at XXXX-XX-XX" please so that users looking at the log can have an idea what's going on.

@rvolosatovs
Copy link
Member Author

  1. Yes, but not as a result of renaming(see diff I linked)
  2. No plugins were added in this PR. The sort was incorrect, which was fixed and probably made you believe the neovimhaskell/nvim-hs.vim was added.

@teto
Copy link
Member

teto commented Jun 6, 2019

my bad I went a bit fast. Thanks.

@teto teto merged commit 43ba5cb into NixOS:master Jun 6, 2019
@rvolosatovs rvolosatovs deleted the update/vim-plugins branch June 6, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants