New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libblockdev: add gptfdisk as a dependency #62757
Conversation
This fixes NixOS#62749 (sgdisk needed for creating luks-encrypted ext4 volumes via udisk2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a 1M size increase:
$ nix path-info -f https://github.com/lightbulbjim/nixpkgs/archive/libblockdev-sgdisk.tar.gz -S libblockdev
/nix/store/p8wi7jmzx690ycfab0fkskv4mha4wdgp-libblockdev-2.20 258715416
$ nix path-info -f https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz -S libblockdev
/nix/store/5rajvy6hjj10r4la6j1p4gjlp50vsbck-libblockdev-2.20 257905504a
Should fix things as proposed for gnome-disk-utility, note there's more utilities that are expected like this Wouldn't really make sense to carry a patch to hardcode everything though. |
I forgot to mention that gnome-disk-utility only seems to care about There doesn't seem to be anything else in nixpkgs which would rely on further patching either. These are the reverse dependencies according to
As far as I can tell none of them involve creating/formatting filesystems. So I think we're probably safe just to patch the I'd also like it if this could be covered by tests, but without being able to predict new features I'm not sure how to do that effectively. |
It appears that they need Though that being needed isn't mentioned in the documentation I'd assume we couldn't run them without a vm in this case.
I mentioned
I'm assuming, and now with the information you've provided, this should be sufficient. |
Motivation for this change
Certain udisk2 operations (eg creating luks-encrypted ext4 volumes) require libblockdev to have access to the sgdisk utility. This change adds gptfdisk (which includes sgdisk) to libblockdev.
Fixes #62749.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)