-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
habitat: 0.32.2 -> 0.82.0 #63105
habitat: 0.32.2 -> 0.82.0 #63105
Conversation
@@ -1,24 +1,22 @@ | |||
{ lib, fetchFromGitHub, rustPlatform, pkgconfig | |||
, libsodium, libarchive, openssl }: | |||
, libsodium, libarchive, openssl, zeromq }: | |||
|
|||
with rustPlatform; | |||
|
|||
buildRustPackage rec { | |||
name = "habitat-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid repetition
name = "habitat-${version}"; | |
pname = "habitat"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve seen it either way here, so leaving it as it was unless someone else feels strongly about it.
Co-Authored-By: Pierre <pierreis@users.noreply.github.com>
Co-Authored-By: Pierre <pierreis@users.noreply.github.com>
Co-Authored-By: Pierre <pierreis@users.noreply.github.com>
@rushmorem or perhaps @Mic92 review? |
The build has been broken on master for a very long time, for want of an upgrade. This continues the effort put forth here: NixOS#63105 Note that while there are newer versions than this, upgrading to those requires getting some Cargo protobuf dependencies to compile. Since this fixes the failing build, it seems like a good start. Upstream does not appear to have any Darin builds in their CI, and we do not have a Darwin maintainer available, so this disables it as well.
Superseded by #82213. Closing. |
Motivation for this change
New attempt after closing #46138
Fixes the cargoSha256 problem here for habitat: #62047
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)