Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sslsplit: init at 0.5.5 #63922

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@contrun
Copy link
Contributor

contrun commented Jun 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

mmahut left a comment

Welcome to nixpkgs :)

Beside the inline comments, the package builds fine and the binaries are working as expected. However, the sample configuration file sslsplit.conf.sample is in the root of the package, should be probably moved to doc.

pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
@contrun contrun force-pushed the contrun:sslsplit branch from 47c56dc to 9b870df Jun 30, 2019
Copy link
Contributor

aanderse left a comment

Looking good! I have left a few minor suggestions I hope you will find helpful. And as @mmahut said, welcome!

pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
@contrun contrun force-pushed the contrun:sslsplit branch from 9b870df to b03cf88 Jun 30, 2019
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Aug 13, 2019

Any updates?

@contrun

This comment has been minimized.

Copy link
Contributor Author

contrun commented Aug 14, 2019

@mmahut Please see this comment #63922 (comment)

@contrun contrun force-pushed the contrun:sslsplit branch from b03cf88 to 567549c Aug 14, 2019
@contrun contrun force-pushed the contrun:sslsplit branch from 567549c to d6bb6ce Nov 26, 2019
@contrun contrun force-pushed the contrun:sslsplit branch from d6bb6ce to e7d12a4 Nov 26, 2019
@contrun contrun changed the title sslsplit: init at 0.5.4 sslsplit: init at 0.5.5 Nov 26, 2019
@contrun contrun requested review from jtojnar, mmahut and aanderse Nov 26, 2019
@contrun

This comment has been minimized.

Copy link
Contributor Author

contrun commented Nov 26, 2019

@GrahamcOfBorg build sslsplit

@aanderse aanderse merged commit f4cb37f into NixOS:master Dec 3, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sslsplit on aarch64-linux Success
Details
sslsplit on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.