Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psrecord: init at 1.1 #63953

Merged
merged 1 commit into from Jul 1, 2019
Merged

psrecord: init at 1.1 #63953

merged 1 commit into from Jul 1, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Jun 30, 2019 •
edited

Motivation for this change

Allows for simple RAM usage measurements, e.g.:

psrecord --plot plot.png "nix-env -qa hello"

plot

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough to me. Haven't tested but merging based on @JohnAZoidberg being a fantastic contributor 😄

Thanks @JohnAZoidberg!

@aanderse aanderse merged commit 795c7fa into NixOS:master Jul 1, 2019
@JohnAZoidberg
Copy link
Member Author

Oh come on, I even gave a simple example to test with :P
But thanks :)

@JohnAZoidberg JohnAZoidberg deleted the psrecord branch July 1, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @aanderse