Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: MACOSX_DEPLOYMENT_TARGET 10.10 -> 10.12 #64458

Merged
merged 1 commit into from Jul 22, 2019
Merged

stdenv: MACOSX_DEPLOYMENT_TARGET 10.10 -> 10.12 #64458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/stdenv/darwin/default.nix
View file
Open in desktop
Expand Up @@ -32,7 +32,7 @@ in rec {
export NIX_ENFORCE_NO_NATIVE="''${NIX_ENFORCE_NO_NATIVE-1}"
export NIX_IGNORE_LD_THROUGH_GCC=1
stripAllFlags=" " # the Darwin "strip" command doesn't know "-s"
export MACOSX_DEPLOYMENT_TARGET=10.10
export MACOSX_DEPLOYMENT_TARGET=10.12
export SDKROOT=
export CMAKE_OSX_ARCHITECTURES=x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a no-op. CMAKE_OSX_ARCHITECTURES should be in cmakeFlags, not an env var. I believe this can be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gl_cv_func_getcwd_abort_bug can be removed as well

# Workaround for https://openradar.appspot.com/22671534 on 10.11.
Expand Down