Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writefreely: init at 0.10.0 #64564

Closed
wants to merge 1 commit into from

Conversation

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Jul 10, 2019

Motivation for this change

My attempt with #63335

Does not work yet though. If someone has experience with go packaging, please give it a try!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Jul 10, 2019

[...]
github.com/writeas/writefreely/migrations
github.com/writeas/writefreely/page
github.com/writeas/writefreely/parse
github.com/writefreely/go-nodeinfo
github.com/writeas/writefreely
# github.com/writeas/writefreely
./app.go:719:17: undefined: Asset
builder for '/nix/store/cxxmd0ihdp3p14yc4mhm1l5vjkc4f51j-writefreely-0.10.0.drv' failed with exit code 1
error: build of '/nix/store/cxxmd0ihdp3p14yc4mhm1l5vjkc4f51j-writefreely-0.10.0.drv' failed
@manveru

This comment has been minimized.

Copy link
Contributor

manveru commented Jul 12, 2019

The error comes from not running https://github.com/writeas/writefreely/blob/develop/Makefile#L113
We'll probably need a separate drv for the go-bindata executable.

@kalbasit

This comment has been minimized.

Copy link
Member

kalbasit commented Jul 13, 2019

The error comes from not running https://github.com/writeas/writefreely/blob/develop/Makefile#L113
We'll probably need a separate drv for the go-bindata executable.

This should be done in the preBuild hook. However, it's not possible to pass that to the modules yet and it needs some work. I don't have any resources this weekend/week so it'll have to wait till next weekend unless someone wants to take a stab at it first.

@matthiasbeyer matthiasbeyer deleted the matthiasbeyer:try-writefreely branch Nov 9, 2019
@dongcarl

This comment has been minimized.

Copy link
Contributor

dongcarl commented Dec 25, 2019

Hi @kalbasit @matthiasbeyer, I'd like to take a stab at this but am not sure how to create a separate drv for the go-bindata executable in the preBuild hook, any pointers would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.