Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-packages-v10: add sass cli program #64566

wants to merge 2 commits into from


Copy link

@proger proger commented Jul 10, 2019

Adding nodePackages.sass which is a popular css preprocessor CLI according to node section of nixpkgs manual. Includes a regen commit.

Checklist (i consider unchecked as inapplicable):

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@mattmelling mattmelling commented Jul 13, 2019

This builds fine and works for me, but I get the following building under nix-review:

$ nix-review  pr 64566
$ git fetch --force master:refs/nix-review/0 pull/64566/head:refs/nix-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 6 (delta 4), reused 6 (delta 4), pack-reused 0
Unpacking objects: 100% (6/6), done.
   263b5244efd..23a51a61d8e  master     -> refs/nix-review/0
$ git worktree add /home/matt/.cache/nix-review/pr-64566-2/nixpkgs 23a51a61d8ea5c56d2f108bbb04ac7a2409ab58a
Preparing worktree (detached HEAD 23a51a61d8e)
HEAD is now at 23a51a61d8e vimPlugins: update (#64696)
$ git merge --no-commit 7178a4b14518b0fcee47ae2562595aa26dc4b8f9
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/matt/.cache/nix-review/pr-64566-2/build.nix
builder for '/nix/store/4a40gd2s35aczg7kkf16hmjz9sb6l27d-meguca-unstable-2019-03-12.drv' failed with exit code 2; last 10 log lines:
cannot build derivation '/nix/store/2wmq524fnvx7fy68sk0kpzrvgx1vclma-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/2wmq524fnvx7fy68sk0kpzrvgx1vclma-env.drv' failed
2 package are marked as broken and were skipped:
casperjs facette

1 package failed to build:

15 package were build:
azure-cli create-cycle-app fast-cli joplin lessc lumo npm2nix python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.oauthenticator shout sloc styx triton wasm-text-gen

Copy link

@prusnak prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

Copy link

@ryantm ryantm commented Oct 16, 2020

merged via #100606

@ryantm ryantm closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants