Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdlib: init at 1.4.0 #64685

Merged
merged 2 commits into from Jul 16, 2019
Merged

tdlib: init at 1.4.0 #64685

merged 2 commits into from Jul 16, 2019

Conversation

vyorkin
Copy link
Member

@vyorkin vyorkin commented Jul 12, 2019

Motivation for this change

Adds the tdlib -- a cross-platform library for building Telegram clients.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/libraries/tdlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tdlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tdlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tdlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tdlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tdlib/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@vyorkin Are you interested in being listed as the package mantainer?

@risicle
Copy link
Contributor

risicle commented Jul 14, 2019

This appears to build fine on darwin too (macos 10.13), so you should be able to enable that.

@vyorkin
Copy link
Member Author

vyorkin commented Jul 14, 2019

@aanderse Yes, sure! I've updated the meta and added myself to the maintainer-list.nix

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@vyorkin Thanks for choosing to contribute to nixpkgs!

@aanderse
Copy link
Member

@GrahamcOfBorg build tdlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants