New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.starfish: init at 0.1.3 #64692
Conversation
Result of 15 package were build:
|
304fd2f
to
bb12135
Compare
Result of 15 package were build:
|
To get
Note I often tend to take (TBH it might be worth taking the condition out of that and just doing it for all platforms as it will remove the risk of any platform attempting to e.g. open an X server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the above fix, nox-review
is happy for me on non-nixos linux x86_64 and macos 10.13.
Great work on the tests 👍
bb12135
to
8687fdf
Compare
@risicle your requested change has been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick little review, forgot to request changes. See above comments
# specifically needed for darwin
export HOME=$(mktemp -d)
mkdir -p $HOME/.matplotlib
echo "backend: ps" > $HOME/.matplotlib/matplotlibrc @worldofpeace this is needed for the darwin compatibility. Should I do an |
8687fdf
to
f548b27
Compare
Yeah or even wrap it with
inside the |
f548b27
to
bf3dec9
Compare
@worldofpeace changes have been made and it builds locally for me. |
Result of 15 package were build:
|
Ready for merge |
Motivation for this change
Great scipy talk and wanted to package starfish.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)