Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telega-server: init at 0.4.0 #64977

Closed
wants to merge 1 commit into from

Conversation

@vyorkin
Copy link
Contributor

commented Jul 17, 2019

Motivation for this change

Adds the telega-server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mmahut

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

@GrahamcOfBorg build telega-server

@vyorkin vyorkin force-pushed the vyorkin-forks:telega-server/init branch from e1c5518 to 7840e98 Jul 19, 2019

@vyorkin vyorkin changed the title telega-server: init at 2019-07-10 telega-server: init at 0.4.0 Jul 19, 2019

@vyorkin vyorkin force-pushed the vyorkin-forks:telega-server/init branch from 7840e98 to 7da8de1 Jul 19, 2019

@jollheef

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Tested on my machine. It works.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@GrahamcOfBorg build telega-server

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Does this require code external to nixpkgs?

@vyorkin vyorkin force-pushed the vyorkin-forks:telega-server/init branch from 7da8de1 to 617b64c Aug 12, 2019

@vyorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@worldofpeace Thanks! I've updated the PR. Could you please explain what is the "code external to nixpkgs"? The README says that it only requires the tdlib package

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@worldofpeace Thanks! I've updated the PR. Could you please explain what is the "code external to nixpkgs"? The README says that it only requires the tdlib package

I found my answer in the README

I'm not familiar with Emacs at all but I'm certain we have some sort of infrastructure for this.

https://nixos.org/nixpkgs/manual/#sec-emacs

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

perhaps cc @adisbladis?

@adisbladis

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

We already have telega packaged in Nixpkgs (along with the rest of Melpa) in the emacsPackagesNg package set.

You're better of building the server as a part of emacsPackagesNg.telega by adding an override in https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/editors/emacs-modes/melpa-packages.nix#L38 as if I understand things correctly the server doesn't make sense without the emacs bits and vice versa.

@vyorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@adisbladis @worldofpeace Thank you for the explanation! Personally, I don't use Nix for managing Emacs packages. So for me (and maybe others like me), it still might make sense to have the telega-server as a separate package. What do you think?

If I understand correctly, I should add an override to the melpa-packages.nix (as part of this PR?), smth like this:

telega = super.telega.overrideAttrs (attrs: {
  buildInputs = (attrs.buildInputs or []) ++ [
    external.telega-server
  ];

Is that right?

@adisbladis

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@vyorkin I added the server build in 7bad929.
If you want to get just the binary you could get it from the output of the generated package.

@vyorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Gotcha! Thanks, @adisbladis!

@vyorkin vyorkin closed this Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.