Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: 1.43.0 -> 1.44.5 #65670

Closed
wants to merge 1 commit into from
Closed

pango: 1.43.0 -> 1.44.5 #65670

wants to merge 1 commit into from

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 31, 2019

Motivation for this change

pango: 1.43.0 -> 1.44.1

Also fixes #65651.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@worldofpeace
Copy link
Contributor

Should go to staging.

@mmahut mmahut changed the base branch from master to staging July 31, 2019 16:41
@mmahut mmahut changed the base branch from staging to master July 31, 2019 16:42
@mmahut mmahut changed the base branch from master to staging-next July 31, 2019 16:48
@jtojnar
Copy link
Contributor

jtojnar commented Jul 31, 2019

@jtojnar
Copy link
Contributor

jtojnar commented Jul 31, 2019

Also note that this release removes support for some bitmap font formats, which some users can still be relying on:

https://gitlab.gnome.org/GNOME/pango/issues/386

@dtzWill
Copy link
Member

dtzWill commented Aug 1, 2019

https://gitlab.gnome.org/GNOME/pango/blob/1.44.1/NEWS <-- maybe bump to this?

FWIW lilypond and inkscape (so far) are failing to build after moving to 1.44.1 -- haven't tried with 1.44.0, so dunno but just heads-up regardless. Looking forward to the bump!

@mmahut
Copy link
Member Author

mmahut commented Aug 13, 2019

@GrahamcOfBorg build inkscape lilypond

@mmahut mmahut changed the title pango: 1.43.0 -> 1.44.1 pango: 1.43.0 -> 1.44.4 Aug 13, 2019
@mmahut mmahut removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Aug 13, 2019
@mmahut
Copy link
Member Author

mmahut commented Aug 13, 2019

@GrahamcOfBorg build lilypond-unstable

@dtzWill
Copy link
Member

dtzWill commented Aug 14, 2019

Phew, 1.44.4 LGTM so far-- builds through inkscape/lilypond locally now \o/.

FWIW: https://gitlab.freedesktop.org/cairo/cairo/issues/370 -- I'm still building but even when that's done may only be able to report if things are dramatically impacted O:). So if someone with sharper eyes or familiarity might wanna check we don't regress font rendering as some users encounter (unless using latest cairo git).

Also, as an experiment I've been rocking freetype w/o cleartype (to see how the default ("Harmony"?) rendering compares) so whatever I end up seeing re:subpixel behavior is likely not representative anyway....

@dtzWill
Copy link
Member

dtzWill commented Aug 14, 2019

@GrahamcOfBorg build python2Packages.pygtk

@mmahut mmahut changed the title pango: 1.43.0 -> 1.44.4 pango: 1.43.0 -> 1.44.5 Aug 15, 2019
@mmahut
Copy link
Member Author

mmahut commented Aug 23, 2019

@GrahamcOfBorg build python2Packages.pygtk

@FRidh FRidh changed the base branch from staging-next to staging August 31, 2019 14:06
@FRidh FRidh added this to the 19.09 milestone Aug 31, 2019
@worldofpeace
Copy link
Contributor

Tbh, this is something that I'd consider merging after the release...
Other opinions are welcome though.

@mmahut
Copy link
Member Author

mmahut commented Sep 1, 2019

@worldofpeace I agree, I don't think we will have this working before anyway.

@worldofpeace
Copy link
Contributor

Right, issues with fonts are already pretty dissatisfying for users, I believe arch is just using cairo master and I don't think we should do this.

@disassembler
Copy link
Member

disassembler commented Sep 2, 2019

@mmahut @dtzWill netbsd, LFS and archlinux all have similar bugs reported with building pygtk with this pango:

pango.c:8650:55: error: ‘PANGO_TYPE_FONTSET_SIMPLE’ undeclared (first use in this function); did you mean ‘PANGO_TYPE_FONT_FAMILY’?
     pygobject_register_class(d, "PangoFontsetSimple", PANGO_TYPE_FONTSET_SIMPLE, &PyPangoFontsetSimple_Type, Py_BuildValue("(O)", &PyPangoFontset_Type));
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
                                                       PANGO_TYPE_FONT_FAMILY

@worldofpeace
Copy link
Contributor

@disassembler I think we can get the security fixes without bumping to 1.44.

@disassembler disassembler modified the milestones: 19.09, 20.03 Sep 2, 2019
@dtzWill dtzWill mentioned this pull request Sep 5, 2019
10 tasks
@worldofpeace
Copy link
Contributor

Pango re-added the PangoFontsetSimple

So hopefully pygtk can build with that commit now.
(probably need to disable a lot of warnings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants