Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zathura: drop broken synctexSupport option #65743

Merged
merged 1 commit into from Aug 1, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 1, 2019

Motivation for this change

Resolves #65553
The option was not tested since its introduction in b21329e. It is currently broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl
Copy link
Member Author

veprbl commented Aug 1, 2019

cc @rnhmjoj @rembo10

@globin globin merged commit 9195186 into NixOS:master Aug 1, 2019
mnacamura added a commit to mnacamura/etc-nixos that referenced this pull request Aug 6, 2019
@veprbl veprbl deleted the pr/zathura_drop_no_synctex branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zathura doesn't build if synctexSupport is set
2 participants