Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to specify
BASHCOMPDIR
in$out
to keep things pure.Motivation for this change
pass-otp
has been outdated since november 2018 apparently.Things done
I bumped this because the build failed on my machine, a mac. It still fails so I haven't been able to test the changes. The previous version worked fine on another mac so I think the build failure is specific to my machine.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @
EDIT: Managed to build it on another mac. And it generated an otp just fine.
P.s.: Should I add myself as a maintainer? If I'm using this anyway I don't mind keeping it up to date.