Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gnome3: default support for color emoji #67215

Closed
wants to merge 1 commit into from

Conversation

@worldofpeace
Copy link
Member

commented Aug 21, 2019

Motivation for this change

Pretty sure color emoji should just work out of the box here.
I'm not sure if the default font has changed, but I think it was noto-fonts-emoji.

Things done

These emojis show up properly in GTK3 apps.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

];

fonts.fontconfig.penultimate.enable = false;

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer Aug 21, 2019

Member

Does this interfere with emojis?

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Aug 21, 2019

Author Member

It does, and it doesn't. I should probably mark this as wip since @jtojnar and I are still figuring this out. In particular people who try to use a different emoji font than the one we've configured will be stuck with this one. Thinking there should substitution rules, but I'm not too familiar with these pieces.

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Aug 21, 2019

Author Member

@matthewbauer It appears penultimate is missing an emoji family.

This comment has been minimized.

Copy link
@matthewbauer

This comment has been minimized.

Copy link
@ttuegel

ttuegel Aug 22, 2019

Member

It appears penultimate is missing an emoji family.

I don't know what this means. 🙁

This comment has been minimized.

Copy link
@jtojnar

jtojnar Aug 22, 2019

Contributor

@ttuegel in 45-generic.conf & 60-generic.conf in fontconfig package, there is emoji family defined.

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

fontconfig-ultimate had the preset option removed with the infimality patches in 6559283 but then it was re-added in d0954b5. Why was that so?

@worldofpeace worldofpeace referenced this pull request Aug 26, 2019
0 of 10 tasks complete
@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

Superseded by #67522 because of the rewrite.

@worldofpeace worldofpeace deleted the worldofpeace:gnome-emoji branch Aug 26, 2019
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Aug 26, 2019
It currently lacks an emoji font-family which means it has to be
disabled for them to function [0].  Additionally it's fallen out of
necessity to ship custom font rendering settings (as far as I'm aware
of).

[0]: NixOS#67215
@worldofpeace worldofpeace referenced this pull request Aug 26, 2019
0 of 10 tasks complete
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Aug 29, 2019
It currently lacks an emoji font-family which means it has to be
disabled for them to function [0].  Additionally it's fallen out of
necessity to ship custom font rendering settings (as far as I'm aware
of).

[0]: NixOS#67215
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Aug 30, 2019
It currently lacks an emoji font-family which means it has to be
disabled for them to function [0].  Additionally it's fallen out of
necessity to ship custom font rendering settings (as far as I'm aware
of).

[0]: NixOS#67215
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Sep 12, 2019
It currently lacks an emoji font-family which means it has to be
disabled for them to function [0].  Additionally it's fallen out of
necessity to ship custom font rendering settings (as far as I'm aware
of).

[0]: NixOS#67215

(cherry picked from commit 0d220e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.