New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uq: init at 2018-05-27 #67380
uq: init at 2018-05-27 #67380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few minor nitpicks. Thanks for contributing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. I think I've fixed everything.
@doronbehar I think you forgot to force push your changes. |
@doronbehar your changes look good 👍 Squash your commits into a single |
@aanderse did you catch my force push? |
@GrahamcOfBorg build uq |
@doronbehar oops! Need to add to the package list! |
I wonder how that got missed. Now @ofborg should build it. |
Thanks @doronbehar 🎉 |
Thank you! 🍻 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)