gamemode: init at 1.4

[leo60228]

Motivation for this change

GameMode is a pretty popular package. It requires a daemon as well, which I have not written a NixOS module for due to a lack of experience. If necessary, I can add it to this or a separate PR.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Had issues with it while reinstalling NixOS, so disabled it
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[frio]

I've got a similar package I've been working on. There's a few more patches I've added in prep for a NixOS module to add the daemon; in particular, setting the default config file location (/usr/share/gamemode won't exist in a running NixOS), fixing the dlopen call, and fixing the polkit calls. I don't have the LD_LIBRARY changes you do, so maybe the second two changes I've made are redundant. If you're OK with this sitting for a day (work's busy atm), I can push you the config file patch?

Also -- some games that can be run with this are still 32-bit, so I tried to get a multiarch build going but eventually had to give up. Have you looked into that at all? (Oh, and -- once done, I might see if we can add this as a dependency for Lutris so that it can toggle gamemode on).

This is exciting, thanks for doing this :).

[frio]

For reference: https://gist.github.com/frio/03a2731903bf40ae0c11b2c99a24dedf. I've got no further input, I'm really happy to see this and would be happy to put together a module when merged :).

[drewrisinger]

A few small suggestions.

[drewrisinger]

Suggested change

	rev = "7ced21f4b30cc4ceb67928889bc57af8784f1009";
	rev = version;

[drewrisinger]

Quote homepage per RFC45

[Atemu]

Or simply use src.meta.homepage ;)

[Kloenk]

Fixes: #84682

[ryantm]

Please apply drewrisinger's changes

[SuperSandro2000]

Suggested change

	{ stdenv, meson, ninja, fetchFromGitHub, systemd, pkgconfig, dbus }:
	{ stdenv, meson, ninja, fetchFromGitHub, systemd, pkg-config, dbus }:

[SuperSandro2000]

Suggested change

	nativeBuildInputs = [ meson ninja pkgconfig ];
	nativeBuildInputs = [ meson ninja pkg-config ];

[kira-bruneau]

I would love to see this merged! @leo60228 are you still willing to maintain this? The suggestions in this PR haven't been resolved and this has been stale for a while now.

I'd be willing to start a new PR based off of this using v1.6.1 + a NixOS module.

[leo60228]

I've mostly lost interest in this package. It'd be great if you were willing to make a new PR, though!

[kira-bruneau]

I've created a new PR for GameMode here: #123433 🙂