Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cue: 0.0.3 -> 0.0.11 #68668

Merged
merged 1 commit into from Sep 15, 2019
Merged

cue: 0.0.3 -> 0.0.11 #68668

merged 1 commit into from Sep 15, 2019

Conversation

pblkt
Copy link
Contributor

@pblkt pblkt commented Sep 13, 2019 •
edited

Motivation for this change

Version bump for the CUE configuration language

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @solson

@ofborg ofborg bot requested review from kalbasit and solson September 13, 2019 15:24
@solson solson mentioned this pull request Sep 13, 2019
Closed
10 tasks
@kalbasit
Copy link
Member

@GrahamcOfBorg build cue

aanderse
aanderse approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes, and I was able to run the executable (though I have no idea what it does 😄).

@aanderse aanderse merged commit 3866029 into NixOS:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solson solson solson approved these changes

@aanderse aanderse aanderse approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pblkt @kalbasit @solson @aanderse