Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jotta-cli: init at 0.6.18626 #69326

Merged
merged 1 commit into from Sep 29, 2019
Merged

jotta-cli: init at 0.6.18626 #69326

merged 1 commit into from Sep 29, 2019

Conversation

evenbrenden
Copy link
Contributor

@evenbrenden evenbrenden commented Sep 23, 2019

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evenbrenden
Copy link
Contributor Author

Wanted to keep this simple and safe, so I only added binaries for platforms that I could test myself.

@hedning
Copy link
Contributor

hedning commented Sep 26, 2019

jotta-cli ships with completion, something like jotta-cli completion > $out/share/bash-completion/completions/jotta-cli.bash in the fixup phase should do.

Otherwise LGTM :)

@evenbrenden
Copy link
Contributor Author

@hedning Thanks, added!

@hedning
Copy link
Contributor

hedning commented Sep 28, 2019

Squash everything into one commit and we're good to go :)

Reviewed-by: Tor Hedin Brønner <torhedinbronner@gmail.com>
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hedning hedning merged commit 9717d35 into NixOS:master Sep 29, 2019
@hedning
Copy link
Contributor

hedning commented Sep 29, 2019

Opted to ignore the systemd unit they ship. It seems really annoying to use as it runs as a separate user. Something like this in ~/.config/autostart/jottad.desktop is probably better:

  [Desktop Entry]
  Name=Jottad
  Exec=systemd-run --user --unit=jottad jottad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants