Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.rider: fix on darwin #69349

Merged
merged 1 commit into from Sep 24, 2019
Merged

jetbrains.rider: fix on darwin #69349

merged 1 commit into from Sep 24, 2019

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Sep 24, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vcunat @Mic92

@uri-canva
Copy link
Contributor Author

Disabled in 9892d5a

@uri-canva uri-canva mentioned this pull request Sep 24, 2019
Merged
10 tasks
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Sep 24, 2019
@vcunat
Copy link
Member

vcunat commented Sep 24, 2019 •
edited

I suspected this would work, but I have no Darwin at hand to verify it runs OK.

@Mic92 Mic92 merged commit f7f356a into NixOS:master Sep 24, 2019
@uri-canva uri-canva deleted the rider branch June 29, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uri-canva @vcunat @Mic92