Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obitools3: init at 3.0.0-beta14 #69644

Merged
merged 1 commit into from Sep 24, 2020
Merged

obitools3: init at 3.0.0-beta14 #69644

merged 1 commit into from Sep 24, 2020

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Sep 27, 2019

Motivation for this change

Obitools is an application developped into my lab and we would be very glad to have it available as a nix package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bzizou
Copy link
Contributor Author

bzizou commented Apr 24, 2020

Can this very old PR be reviewed? I just updated to the master branch, and latest version. This package has been heavily tested in production as we have the same into our NUR repo that is used on our HPC clusters.

@bzizou bzizou changed the title obitools3: init at 3.0.0-beta1 obitools3: init at 3.0.0-beta14 Apr 24, 2020
@ryantm
Copy link
Member

ryantm commented Sep 24, 2020

Result of nixpkgs-review pr 69644 1

1 package built:
- obitools3

@ryantm ryantm merged commit dfd2eea into NixOS:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants