Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ispc: do not test on the "host" target #70260

Merged
merged 1 commit into from Oct 8, 2019
Merged

ispc: do not test on the "host" target #70260

merged 1 commit into from Oct 8, 2019

Conversation

athas
Copy link
Contributor

@athas athas commented Oct 2, 2019 •
edited

This is because some very sensitive tests may fail when using more
exotic platforms and vector instructions. For example, floating point
summation (which is not associative in the first place), or
transcendental functions. Arguably, ispc's test suite is too
sensitive here.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@srhb srhb self-requested a review October 2, 2019 17:34
@grahamc
Copy link
Member

grahamc commented Oct 2, 2019

Please change your commit message to say ispc: do not test on the "host" target

@srhb
Copy link
Contributor

srhb commented Oct 2, 2019

cc @aristidb

@athas
ispc: do not test on the "host" target
12f03a0 
This is because some very sensitive tests may fail when using more
exotic platforms and vector instructions.  For example, floating point
summation (which is not associative in the first place), or
transcendental functions.  Arguably, ispc's test suite is too
sensitive here.
@ofborg ofborg bot requested a review from aristidb October 2, 2019 17:48
@athas athas changed the title Do not test on the "host" target. ispc: do not test on the "host" target Oct 3, 2019
@athas
Copy link
Contributor Author

athas commented Oct 8, 2019

Relevant for #68361.

@srhb srhb merged commit ec358ab into NixOS:master Oct 8, 2019
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Oct 8, 2019
@athas @srhb
ispc: do not test on the "host" target
7c4a194 
This is because some very sensitive tests may fail when using more
exotic platforms and vector instructions.  For example, floating point
summation (which is not associative in the first place), or
transcendental functions.  Arguably, ispc's test suite is too
sensitive here.

(cherry picked from commit 12f03a0)
Backport of NixOS#70260
@srhb srhb mentioned this pull request Oct 8, 2019
Closed
10 tasks
@athas athas mentioned this pull request Oct 14, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@aristidb aristidb Awaiting requested review from aristidb

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@athas @grahamc @srhb