-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] corebird: drop discontinued package and replace with cawbird #70287
Conversation
@Lassulus It'd be nice to get this merged before the 19.09 release |
@GrahamcOfBorg build cawbird |
Do we need to get rid of the |
No, the nixpkgs/pkgs/top-level/aliases.nix Line 33 in d33e497
|
Ah wait this is a backport. |
@worldofpeace So what to do then? Revert the merge of #70168, fix the PR and then backport it + the release notes? |
The release notes and the alias fix need to be on master. |
@worldofpeace Can you revert the merged master PR for me or shall I create a revert PR? |
I'm not sure what needs to be reverted? |
@worldofpeace I thought that reverting the merge of #70168, then fixing it with the alias and release notes and merging it again, might be clenaer then just creating a 2nd PR. But if I have your ok for just doing the fixes in an additional PR I'll go for that. |
Yeah that's typically fine 👍 |
backport of #70168
Additionally, a deprecation notice has been added to the release-19.09 release notes.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)