Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibc: patch CVE-2018-11236, CVE-2018-11237 #70289

Merged
merged 1 commit into from Oct 16, 2019
Merged

glibc: patch CVE-2018-11236, CVE-2018-11237 #70289

merged 1 commit into from Oct 16, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 2, 2019

Motivation for this change

Patches have been imported into nixpkgs and manually edited to avoid
merge conflicts on ChangeLog / NEWS files.

#70093 (security bug)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
glibc: patch CVE-2018-11236, CVE-2018-11237
17be09a 
Patches have been imported into nixpkgs and manually edited to avoid
merge conflicts on ChangeLog / NEWS files.
This was referenced Oct 2, 2019
Merged
Merged
@ofborg ofborg bot requested a review from edolstra October 2, 2019 22:27
@vcunat vcunat self-assigned this Oct 12, 2019
vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #70289: glibc: patch CVE-2018-11236, CVE-2018-11237
51b416e 
into staging
@vcunat
Copy link
Member

vcunat commented Oct 12, 2019

It's in staging; github should auto-close as merged once we start the next staging-next iteration.

@FRidh FRidh merged commit 17be09a into NixOS:staging-next Oct 16, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 22, 2019
@vcunat @dtzWill
Merge NixOS#70289: glibc: patch CVE-2018-11236, CVE-2018-11237
b10d03b 
into staging

(cherry picked from commit 51b416e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @vcunat @veprbl @FRidh