Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm: 19.05.2.1 -> 19.05.3.2 #70373

Merged
merged 1 commit into from Oct 8, 2019
Merged

slurm: 19.05.2.1 -> 19.05.3.2 #70373

merged 1 commit into from Oct 8, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Oct 4, 2019 •
edited

Motivation for this change

Regular update
https://github.com/SchedMD/slurm/blob/slurm-19.05/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    nixos/tests/slurm.nix
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jagajaga October 4, 2019 09:30
@markuskowa
Copy link
Member Author

markuskowa commented Oct 4, 2019 •
edited

@GrahamcOfBorg test slurm

@markuskowa
Copy link
Member Author

Not sure why the test fail with ofBorg. They work fine locally.
It seems that there is general problem with ofBorg and tests and the moment.
Having the same issue here: #67591, #67749

@markuskowa markuskowa merged commit cfcc975 into NixOS:master Oct 8, 2019
@markuskowa markuskowa deleted the upd-slurm branch October 8, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markuskowa