Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eternal-terminal: 5.1.10 -> 6.0.4 #70419

Closed
wants to merge 1 commit into from

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Oct 4, 2019

Motivation for this change

Simple version bump.

Tested working between two NixOS machines (client/server).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 9, 2019

@qolii it seems v6.0.4 was released in the meantime, with some bugfixes.

@qolii qolii force-pushed the eternal_terminal_5.1.10__6.0.3 branch from 39e49c9 to 4b2f706 Compare October 9, 2019 18:44
@qolii
Copy link
Contributor Author

qolii commented Oct 9, 2019

it seems v6.0.4 was released in the meantime, with some bugfixes

Thanks! Bumped.

@qolii qolii changed the title eternal-terminal: 5.1.10 -> 6.0.3 eternal-terminal: 5.1.10 -> 6.0.4 Oct 9, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 9, 2019

@GrahamcOfBorg build eternal-terminal

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 9, 2019

I can build and run etserver v6.0.4 properly on my end (nixos).
But ofBorg's Darwin failure seems to be a regression.

@qolii qolii mentioned this pull request Oct 31, 2019
10 tasks
@qolii
Copy link
Contributor Author

qolii commented Oct 31, 2019

@c0bw3b, can you explain further? I don't know how ofBorg works!

FWIW, I just ran

NIX_PATH="nixpkgs=https://github.com/NixOS/nixpkgs/archive/4b2f7063f617bcc0eb50de19f660a4f9a50a1488.tar.gz" nix-shell -p eternal-terminal

on my Mac, and everything works as expected (connecting to a NixOS et server).

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2019

How ofBorg builds is explained on its readme
To try and reproduce the build failure on a mac, you may also use nix-review

In this instance, I think it's just that ninja isn't really recommended to build. Plain cmake will do just fine.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2019

So closing in favor of #71915
(doesn't prevent you to update it in the future and notify maintainers :) )

@c0bw3b c0bw3b closed this Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants