Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: apply patches for CVE-2018-16548 #70558

Merged
merged 1 commit into from Oct 12, 2019
Merged

zziplib: apply patches for CVE-2018-16548 #70558

merged 1 commit into from Oct 12, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 7, 2019

Motivation for this change

#70135 (security bug)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Oct 7, 2019
Merged
Merged
@vcunat vcunat self-assigned this Oct 12, 2019
vcunat
vcunat approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I suppose. It's "only" fixing memory leaks, so I don't consider that really important.

vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #70558: zziplib: apply patches for CVE-2018-16548
758b2e4 
...into staging-next
@vcunat vcunat merged commit aa74d07 into NixOS:staging-next Oct 12, 2019
@delroth
Copy link
Contributor Author

delroth commented Oct 12, 2019

@vcunat mind merging the two backports #70559 #70560 as well?

@vcunat
Copy link
Member

vcunat commented Oct 12, 2019

Yes, I know about them. I'll hope these won't introduce an even worse problem, e.g. double-free error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @vcunat @veprbl