Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argo: 2.2.1 -> 2.4.1 #70672

Merged
merged 1 commit into from
Oct 13, 2019
Merged

argo: 2.2.1 -> 2.4.1 #70672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkgs/applications/networking/cluster/argo/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,18 @@

buildGoPackage rec {
pname = "argo";
version = "2.2.1";
version = "2.4.1";

src = fetchFromGitHub {
owner = "argoproj";
repo = "argo";
rev = "v${version}";
sha256 = "0x3aizwbqkg2712021wcq4chmwjhw2df702wbr6zd2a2cdypwb67";
sha256 = "1f9l9d4r0qfhpr2fn17faczcwmwmdz8f56f27cmmnhxz4r7qcm48";
};

goDeps = ./deps.nix;
goPackagePath = "github.com/argoproj/argo";
subPackages = [ "cmd/argo" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why switch to installing only argo? What about the other two commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can keep the other 2 binaries, but they are really only useful inside a Kubernetes Operator context when the full argo system is installed on a cluster.

The argo CLI is what I think is more relevant to users. It's more like a argoctl, but such a project does not exist.

I'm happy to add back the rest of the binaries if you prefer? Or I can add them back if somebody asks for them in the community?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to leave them off. We can add them if someone asks for them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option would be to add a argoFull where they are available. But if the closure saving is minimal I'm okay with them being added back.


meta = with lib; {
description = "Container native workflow engine for Kubernetes";
Expand Down