Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktorrent: mkDerivation #70679

Merged
merged 1 commit into from Nov 7, 2019
Merged

ktorrent: mkDerivation #70679

merged 1 commit into from Nov 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 7, 2019

Motivation for this change

Still found it crashed on me after a few hours (?),
but at least this fixes inability to launch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from edolstra October 7, 2019 23:51
@edolstra
Copy link
Member

edolstra commented Oct 8, 2019

FYI ktorrent works fine for me on 19.09.

Why would changing mkDerivation make it not crash?

@aanderse
Copy link
Member

@edolstra due to some relatively recent changes in qt passing mkDerivation for packages which use libsForQt5.callPackage instead of callPackage is required. See #65399 for details.

aanderse
aanderse approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without doing any testing whatsoever I approve this PR because of #65399.

@matthewbauer matthewbauer merged commit 71d91a9 into NixOS:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @edolstra @aanderse @matthewbauer