Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ispc: use cmake for building. #70851

Merged
merged 1 commit into from Feb 10, 2020
Merged

ispc: use cmake for building. #70851

merged 1 commit into from Feb 10, 2020

Conversation

@athas
Copy link
Contributor

@athas athas commented Oct 9, 2019

The Makefile approach is gone in newer versions of ispc.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aristidb

@athas athas force-pushed the athas:ispc-cmake branch from d4377f6 to cbb0985 Oct 9, 2019
@athas
Copy link
Contributor Author

@athas athas commented Oct 10, 2019

I pushed new changes. It now builds well on my NixOS machine (left my Mac at work so can't test there).

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 10, 2019

@GrahamcOfBorg build ispc

The Makefile approach is gone in newer versions of ispc.
@athas athas force-pushed the athas:ispc-cmake branch from cbb0985 to 4b4b7fd Feb 8, 2020
@athas
Copy link
Contributor Author

@athas athas commented Feb 8, 2020

Any news here? The ispc in Nixpkgs is now two releases behind upstream, presumably because the newer ispcs have removed the Makefiles used by Nixpkgs.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[5 built, 80 copied (1632.2 MiB), 288.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70851
3 package built:
embree2 ispc luxcorerender
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 10, 2020

@GrahamcOfBorg build embree2 ispc luxcorerender

@jonringer jonringer merged commit 170eefb into NixOS:master Feb 10, 2020
17 of 18 checks passed
17 of 18 checks passed
embree2, ispc, luxcorerender on x86_64-linux
Details
embree2, ispc, luxcorerender on aarch64-linux No attempt
Details
ispc on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
embree2, ispc, luxcorerender on x86_64-darwin Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ispc on x86_64-linux Success
Details
@athas
Copy link
Contributor Author

@athas athas commented Feb 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.