Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suricata: 4.1.5 -> 5.0.0 #71281

Merged
merged 1 commit into from Oct 21, 2019
Merged

suricata: 4.1.5 -> 5.0.0 #71281

merged 1 commit into from Oct 21, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Oct 17, 2019

Additional Changes:

  • Disabled AFL build configuration
  • Enabled eBPF support
  • Minor fixes

Closure size grows from 116MB to 141MB.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @magenbluten

@ofborg ofborg bot requested a review from magenbluten October 17, 2019 12:02
@Lassulus
Copy link
Member

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from magenbluten October 17, 2019 15:36
@tobim
suricata: 4.1.5 -> 5.0.0
cdd0f3d 
Additional Changes:
 - Disabled AFL build configuration
 - Enabled eBPF support
magenbluten
magenbluten reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@magenbluten magenbluten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think enabling the new rust snmp, sip and rdp parsers as well makes sense? (at least you have --enable-rust-experimental on). i leave that up to you. otherwise looks very nice.

@tobim
Copy link
Contributor Author

tobim commented Oct 20, 2019

I would keep the experimental stuff disabled for now.

@Lassulus Lassulus merged commit d46de73 into NixOS:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magenbluten magenbluten magenbluten approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobim @Lassulus @magenbluten