Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networkmanager: use tmpfiles to setup state directories #71322

Merged
merged 1 commit into from Oct 18, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 18, 2019

Tmpfiles cleanup mentioned in #71298.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @symphorien

@flokli
Copy link
Contributor Author

flokli commented Oct 18, 2019

Note: I didn't update nm-setup-hostsdirs, which creates directories in /run/NetworkManager/hostsdirs/, each of these allowing a configured user to drop in host files, and reconfigures the NM-provided dnsmasq to watch these directories.

It seems to be a purely nixos-specific feature introduced in #41715 - I couldn't the PR to master.

While I find such a feature by itself pretty scary and would rather not see it in nixpkgs (we have networking.extraHosts and nss for that) - according to systemd's terminilogy, /run/NetworkManager would be considered a RuntimeDirectory, subject to cleanup on each restart of NetworkManager - so it's probably not the right location for "local overrides" anyways. @rickynils, what are your thoughts?

I opened up #71337 to discuss networking.networkmanager.dynamicHosts.

@rickynils

This comment has been minimized.

@worldofpeace
Copy link
Contributor

Thanks for doing this @flokli ❇️

@flokli flokli merged commit c41b37e into NixOS:master Oct 18, 2019
@flokli flokli deleted the networkmanager-tmpfiles branch October 18, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants