Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beam-modules/hex-snapshot: remove #71393

Merged
merged 1 commit into from Nov 17, 2019
Merged

Conversation

DianaOlympos
Copy link
Contributor

@DianaOlympos DianaOlympos commented Oct 19, 2019

Motivation for this change

Most of the reasoning is at #70524. Basically the beam package set is a snapshot of hex. It is not maintained and never got traction in the community. To enable to open the place for different implementation for the BEAM ecosystem, this get rid of this design.

  • Delete hex2nix
  • Delete hex-snapshot
  • Update other packages that uses the snapshot to build to build without
Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gleber @tazjin @ankhers

The package set is not maintained. It is also not used by most of the
BEAM community. Removing it to allow a more useful set of tools fit to
the BEAM community in Nixpkgs.
@DianaOlympos DianaOlympos changed the title [WIP] beam-modules/hex-snapshot: remove beam-modules/hex-snapshot: remove Nov 17, 2019
@DianaOlympos
Copy link
Contributor Author

Ok i squashed and fixed merge conflicts. Would love some review. If all good, let's merge so i can move to the next phase ?

@Mic92
Copy link
Member

Mic92 commented Nov 17, 2019

@GrahamcOfBorg build rebar3 relxExe

@Mic92 Mic92 merged commit 1296f83 into NixOS:master Nov 17, 2019
@cw789
Copy link
Contributor

cw789 commented Nov 18, 2019

Thanks a lot! This step makes the BEAM world within Nix much clearer for future development.
I think #70524 can get closed with this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants