Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 69.0.2 -> 70.0, firefox-esr: 68.1.0esr -> 68.2.0esr #71624

Merged
merged 2 commits into from Oct 22, 2019
Merged

firefox-bin: 69.0.2 -> 70.0, firefox-esr: 68.1.0esr -> 68.2.0esr #71624

merged 2 commits into from Oct 22, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Oct 22, 2019

Motivation for this change

Updates for firefox-bin and firefox-esr. For firefox, see #71580.

Release notes are not published yet.

https://www.mozilla.org/en-US/firefox/70.0/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @andir

@ofborg ofborg bot requested review from edolstra and andir October 22, 2019 05:31
@andir andir self-assigned this Oct 22, 2019
@andir andir merged commit ed8f58f into NixOS:master Oct 22, 2019
@andir andir mentioned this pull request Oct 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees

@andir andir

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taku0 @andir