handbrake: fix missing audio

[acowley]

We build HandBrake with a newer ffmpeg than upstream expects, triggering a problem where the audio samplerate defaults to zero because HandBrake was not explicitly setting it.

This has been fixed in HandBrake upstream, but we must cherry pick this change in order to produce videos with audio until HandBrake 1.3.0 is released.

Motivation for this change

Fix an issue where HandBrake could not produce videos with working audio.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @wmertens @Anton-Latukha

[wmertens]

LGTM!

[Anton-Latukha]

@acowley Thank you for commenting the patch. I understand only people like us, who think about other people.

[woffs]

this should be backported to 19.09

[woffs]

I can approve that

handbrake = pkgs.handbrake.overrideAttrs (old: {
   patches = [(pkgs.fetchpatch {
     name = "set-ffmpeg-samplerate.patch";
     url = "https://patch-diff.githubusercontent.com/raw/HandBrake/HandBrake/pull/2126.patch";
     sha256 = "00lds9h27cvyr53qpvv8gbv01hfxdxd8gphxcwbwg8akqrvk9gbf";
   })];
});

fixes this for 19.09 too :-)