Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

franz: 5.3.3 -> 5.4.1 #71862

Merged
merged 4 commits into from Dec 8, 2019
Merged

franz: 5.3.3 -> 5.4.1 #71862

merged 4 commits into from Dec 8, 2019

Conversation

@davidtwco
Copy link
Member

davidtwco commented Oct 23, 2019

Motivation for this change

v5.4.0 of Franz was released.

I've included a second commit which adds myself as an additional maintainer to this package, as I've submitted a handful of PRs to update this package: #68976, #68899, #68256, #65258 and #62586.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gnidorah

davidtwco added 2 commits Oct 23, 2019
Copy link
Member

gnidorah left a comment

Tested with nix-review pr 71862

@gnidorah

This comment has been minimized.

Copy link
Member

gnidorah commented Oct 24, 2019

@davidtwco Could you please also remove me from maintainers? I see this software went on commercial rails with serious limitations in free plan. I dont care it anymore

For context, see:
#71862 (comment)

Signed-off-by: David Wood <david@davidtw.co>
@davidtwco

This comment has been minimized.

Copy link
Member Author

davidtwco commented Oct 24, 2019

@davidtwco Could you please also remove me from maintainers? I see this software went on commercial rails with serious limitations in free plan. I dont care it anymore

I've updated the PR to do this.

@gnidorah

This comment has been minimized.

Copy link
Member

gnidorah commented Oct 24, 2019

@davidtwco Thank you!

@gnidorah gnidorah mentioned this pull request Oct 26, 2019
3 of 10 tasks complete
@davidtwco

This comment has been minimized.

Copy link
Member Author

davidtwco commented Oct 31, 2019

Added a commit to upgrade to Franz 5.4.1 which has since been released.

@davidtwco davidtwco changed the title franz: 5.3.3 -> 5.4.0 franz: 5.3.3 -> 5.4.1 Oct 31, 2019
Copy link
Contributor

Lassulus left a comment

tested with nix-review

@Lassulus Lassulus merged commit 3e64a0a into NixOS:master Dec 8, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@davidtwco davidtwco deleted the davidtwco:franz-5.4.0 branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.